[Bug 231760] FreeBSD 12.0-ALPHA7 Installations Halts at ACPI on 4 different AMD Ryzen Laptops (HP, DELL, Huawei)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Aug 3 01:36:27 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231760

--- Comment #21 from commit-hook at freebsd.org ---
A commit references this bug:

Author: jhb
Date: Sat Aug  3 01:36:07 UTC 2019
New revision: 350551
URL: https://svnweb.freebsd.org/changeset/base/350551

Log:
  Don't reset memory attributes when mapping physical addresses for ACPI.

  Previously, AcpiOsMemory was using pmap_mapbios which would always map
  the requested address Write-Back (WB).  For several AMD Ryzen laptops,
  the BIOS uses AcpiOsMemory to directly access the PCI MCFG region in
  order to access PCI config registers.  This has the side effect of
  remapping the MCFG region in the direct map as WB instead of UC
  hanging the laptops during boot.

  On the one laptop I examined in detail, the _PIC global method used to
  switch from 8259A PICs to I/O APICs uses a pair of PCI config space
  registers at offset 0x84 in the device at 0:0:0 to as a pair of
  address/data registers to access an indirect register in the chipset
  and clear a single bit to switch modes.

  To fix, alter the semantics of pmap_mapbios() such that it does not
  modify the attributes of any existing mappings and instead uses the
  existing attributes.  If a new mapping is created, this new mapping
  uses WB (the default memory attribute).

  Special thanks to the gentleman whose name I don't have who brought
  two affected laptops to the hacker lounge at BSDCan.  Direct access to
  the affected systems permitted finding the root cause within an hour
  or so.

  PR:           231760, 236899
  Reviewed by:  kib, alc
  MFC after:    2 weeks
  Differential Revision:        https://reviews.freebsd.org/D20327

Changes:
  head/sys/amd64/amd64/pmap.c
  head/sys/i386/i386/pmap.c
  head/sys/i386/i386/pmap_base.c
  head/sys/i386/include/pmap_base.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-acpi mailing list