Please review: D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match

Warner Losh imp at bsdimp.com
Fri Jul 27 16:23:19 UTC 2018


On Fri, Jul 27, 2018 at 9:23 AM, Takanori Watanabe <takawata at init-main.com>
wrote:

> Please review following patch.
> The main purpose of this patch is exclude _CID match from
> acpi_sysresource driver to attach more appropriate driver.
> This patch changes KPI so I want to hear from who may concern.
>
> https://reviews.freebsd.org/D16468


I've looked at it, and I think the KPI change is reasonable (although it
may make merging back to 11 a little harder). I have some minor concerns
about the code, which I voiced in the review.

Warner


More information about the freebsd-acpi mailing list