IASL complains about he same error in two different UEFI firmwares

[Moore, Robert]

We usually see this when:

1) The BIOS dynamically truncates a package at post time by adjusting the length.
2) After disassembly, there is a bunch of code "dangling" around that cannot be compiled.



> -----Original Message-----
> From: owner-freebsd-acpi at freebsd.org [mailto:owner-freebsd-
> acpi at freebsd.org] On Behalf Of O. Hartmann
> Sent: Tuesday, September 23, 2014 6:13 AM
> To: freebsd-acpi at FreeBSD.org
> Subject: IASL complains about he same error in two different UEFI
> firmwares
> 
> 
> Trying to fix an GPU issue on a laptop, I followed the steps as described
> in handbook, chapter 12.17, debugging ASL/AML code.
> 
> I dumped on two different systems the ASL via
> 
> acpidump -dt as described and tried to recompile the result via iasl.
> 
> 
> The outcome is a bit disturbing. IASL complains about the very same errors
> on two diffrent systems.I'll show only one here, since the code block is
> identical.
> 
> System 1:  1
> 
> FreeBSD 11.0-CURRENT #2 r272016: Tue Sep 23 08:20:00 CEST 2014 amd64
> 
> VT: running with driver "vga".
> CPU: Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz (3300.10-MHz K8-class CPU)
>   Origin="GenuineIntel"  Id=0x306a9  Family=0x6  Model=0x3a  Stepping=9
> 
> Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,M
> CA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
> 
> Features2=0x3d9ae3bf<SSE3,PCLMULQDQ,DTES64,MON,DS_CPL,VMX,EST,TM2,SSSE3,CX
> 16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,POPCNT,TSCDLT,XSAVE,OSXSAVE,AVX,F16C>
>   AMD Features=0x28100800<SYSCALL,NX,RDTSCP,LM>
>   AMD Features2=0x1<LAHF>
>   Structured Extended Features=0x281<FSGSBASE,SMEP,ERMS>
>   XSAVE Features=0x1<XSAVEOPT>
>   VT-x: PAT,HLT,MTF,PAUSE,EPT,UG,VPID
>   TSC: P-state invariant, performance statistics real memory  =
> 17179869184 (16384 MB) avail memory = 16286003200 (15531 MB) Event timer
> "LAPIC" quality 600 ACPI APIC Table: <ALASKA A M I>
> 
> 
> 
> root at gate [~] iasl gate.asl
> 
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20130823-64 Copyright (c) 2000 - 2013
> Intel Corporation
> 
> Compiler aborting due to parser-detected syntax error(s)
> gate.asl  12314:         Package (0x06)
> Error    6126 -  syntax error ^
> 
> ASL Input:     gate.asl - 12334 lines, 366705 bytes, 4399 keywords
> 
> Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
> 
> Code portion at line 12314:
> 
> [...]
>         Package (0x06)
>         {
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000
>         }
> 
> 
> 
> System 2:
> 
> 11.0-CURRENT #0 r272019: Tue Sep 23 09:38:59 CEST 2014 amd64
> 
> 
> info: [drm] Initialized drm 1.1.0 20060810
> CPU: Intel(R) Core(TM) i5-4200M CPU @ 2.50GHz (2494.28-MHz K8-class CPU)
>   Origin="GenuineIntel"  Id=0x306c3  Family=0x6  Model=0x3c  Stepping=3
> 
> Features=0xbfebfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,M
> CA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE>
> 
> Features2=0x7fdafbbf<SSE3,PCLMULQDQ,DTES64,MON,DS_CPL,VMX,EST,TM2,SSSE3,<b
> 11>,FMA,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,MOVBE,POPCNT,TSCDLT,AESNI,XSAVE,
> OSXSAVE,AVX,F16C,RDRAND>
>   AMD Features=0x2c100800<SYSCALL,NX,Page1GB,RDTSCP,LM>
>   AMD Features2=0x21<LAHF,ABM>
>   Structured Extended
> Features=0x27ab<FSGSBASE,TSCADJ,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID>
>   XSAVE Features=0x1<XSAVEOPT>
>   VT-x: PAT,HLT,MTF,PAUSE,EPT,UG,VPID
>   TSC: P-state invariant, performance statistics real memory  = 9636413440
> (9190 MB) avail memory = 8149209088 (7771 MB) Event timer "LAPIC" quality
> 600
> ACPI APIC Table: <LENOVO TP-J9   >
> 
> 
> root at hermann: [~] iasl lenovo.asl
> 
> Intel ACPI Component Architecture
> ASL Optimizing Compiler version 20130823-64 Copyright (c) 2000 - 2013
> Intel Corporation
> 
> Compiler aborting due to parser-detected syntax error(s)
> lenovo.asl  18919:         Package (0x06)
> Error    6126 -    syntax error ^
> 
> ASL Input:     lenovo.asl - 18939 lines, 634937 bytes, 7991 keywords
> 
> Compilation complete.
> 
> [...]
>         Package (0x06)
>         {
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000,
>             0x80000000
>         }
> 1 Errors, 0 Warnings, 0 Remarks, 0 Optimizations