MacBookPro 5,1

[Moore, Robert]

Can you send us the acpidump for the machine?

Also, tell us which control method is failing.

Thanks


>-----Original Message-----
>From: owner-freebsd-acpi at freebsd.org [mailto:owner-freebsd-
>acpi at freebsd.org] On Behalf Of Hans Petter Selasky
>Sent: Sunday, October 17, 2010 6:48 AM
>To: freebsd-acpi at freebsd.org
>Cc: linux-acpi at vger.kernel.org
>Subject: Re: MacBookPro 5,1
>
>Hi,
>
>CC'ing the Linux guys, hence I belive you are using the same ACPI code like
>in
>FreeBSD.
>
>It appears that when a string is present in the extended interrupt
>descriptor
>(6.4.3.6, ACPIspec30.pdf), then this is not handled correctly, meaning that
>the precomputed buffer space when encoding to AML, is incorrect and that
>data
>is written beyond the destination buffer!
>
>The error is catched on a MacBookPro 5,1 and is visible if you zero-pad all
>ACPI allocations to 4096 bytes, and verify that the freed buffer is not
>written beyond the allocation. Also the Extended interrupt descriptor must
>be
>the last element encoded in the AML.
>
>The quick patch is to disable these elements. I tried to figure out why
>this
>happens, but this particular handling in the code looks very obfuscated to
>me.
>
>src/sys/contrib/dev/acpica
>%svk diff
>=== resources/rsmisc.c
>==================================================================
>--- resources/rsmisc.c  (revision 213698)
>+++ resources/rsmisc.c  (local)
>@@ -311,6 +311,8 @@
>
>
>         case ACPI_RSC_SOURCEX:
>+               break;  /* RSC_SOURCEX is broken */
>+
>             /*
>              * Optional ResourceSource (Index and String). This is the
>more
>              * complicated case used by the Interrupt() macro
>@@ -537,6 +539,8 @@
>
>
>         case ACPI_RSC_SOURCEX:
>+               break;  /* RSC_SOURCEX is broken */
>+
>             /*
>              * Optional ResourceSource (Index and String)
>              */
>
>
>Any comments are welcome!
>
>--HPS
>
>Please keep me CC'ed.
>_______________________________________________
>freebsd-acpi at freebsd.org mailing list
>http://lists.freebsd.org/mailman/listinfo/freebsd-acpi
>To unsubscribe, send any mail to "freebsd-acpi-unsubscribe at freebsd.org"