kern/150517: [acpi] acpi_ec does not work properly on Lenovo S10[e] (due to dynamic switching to polled mode)

[Andriy Gapon]

The following reply was made to PR kern/150517; it has been noted by GNATS.

From: Andriy Gapon <avg at icyb.net.ua>
To: David Naylor <naylor.b.david at gmail.com>
Cc: bug-followup at freebsd.org
Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo
 S10[e] (due to dynamic switching to polled mode)
Date: Tue, 05 Oct 2010 12:09:02 +0300

 on 02/10/2010 09:31 David Naylor said the following:
 > On Monday 27 September 2010 07:53:51 Andriy Gapon wrote:
 >> Since you already looked at the linux code, could you please post a link to
 >> a place where the problematic condition is handled there?
 >>
 >> P.S. A service like http://lxr.linux.no/ or similar might be convenient.
 > 
 > Sorry for the slow reply.  Your email was mistaken as spam.  I've told gmail 
 > to behave.  
 > 
 > It has been a long time since I looked at the code.  The function in question 
 > is http://lxr.linux.no/linux+v2.6.35.7/drivers/acpi/ec.c#L217 with the actual 
 > check for controller reset at L238.  
 > 
 > Of note is the delay at L254.  It looks like it is almost the same thing my 
 > patch does, except it waits before whereas my patch waits after.  
 
 David,
 
 can you dig up what kind of error messages you were getting from EC before your
 patch?
 
 I also looked at your changes and at what Linux does and came up with some
 changes to make our EC code more robust.  They are significantly based on your
 patch, but also add some additional logic from Linux code.
 
 Can you try the patch?
 http://people.freebsd.org/~avg/acpi_ec.patch
 Thanks a lot!
 
 P.S. I can describe why I didn't include some parts of your changes and what new
 changes I made and "borrowed" from Linux, but later, if you'd like.
 
 -- 
 Andriy Gapon