Two new acpi modules, acpi_wmi and acpi_hp

Rui Paulo rpaulo at freebsd.org
Sun Jun 21 16:56:21 UTC 2009


On 21 Jun 2009, at 17:26, Michael wrote:

> Rui Paulo wrote:
>> On 21 Jun 2009, at 15:08, Rui Paulo wrote:
>>
>>> On 21 Jun 2009, at 12:20, Michael wrote:
>>>
>>>> Hello,
>>>>
>>>> I wrote two new acpi modules last year and finally found the time  
>>>> to fix
>>>> them, add some missing features and write man pages.
>>>
>>> Michael, this is great work! I'll review and see if we can ship it
>>> with 8.0!
>>
>> Michael, this looks good, but there are two style nits that we need  
>> to fix.
>> * we should try not going over the 80 column mark
>> * add a empty new line before every return
>>
>> If you could send me a new patch for 8.0 with these fixes, I'll  
>> commit
>> it (unless someone else has objections).
>>
>> Regards,
>> -- 
>> Rui Paulo
>>
>
> Hi Rui,
>
> hmm style(9) doesn't say anything about columns or return statements  
> in
> this context (maybe it should be updated?!?).

I've been looking again at style(9) and seems like I'm misremembering  
something. Please ignore this request and sorry for the hassle.

--
Rui Paulo



More information about the freebsd-acpi mailing list