CFR: ACPI Dock driver
Søren Schmidt
sos at FreeBSD.org
Fri Apr 14 16:24:13 UTC 2006
On Lør, 2006-04-15 at 01:20 +0900, Mitsuru IWASAKI wrote:
> Hi,
>
> > --- ata-all.c 31 Mar 2006 08:09:04 -0000 1.271
> > +++ ata-all.c 14 Apr 2006 15:39:20 -0000
> > @@ -277,8 +277,8 @@
> > if (!dev || !(ch = device_get_softc(dev)))
> > return ENXIO;
> >
> > - /* wait for the channel to be IDLE before entering suspend mode */
> > - while (1) {
> > + /* wait for the channel to be IDLE or detached before suspending */
> > + while (ch->r_irq) {
> > mtx_lock(&ch->state_mtx);
> > if (ch->state == ATA_IDLE) {
> > ch->state = ATA_ACTIVE;
> >
> > That I'll gladly commit for you instead...
>
> Yes, This have also the same effect. I prefer this.
Good, this one also doesn't relay on a mutx that has been destroyed :)
I'll commit asap...
-Søren
More information about the freebsd-acpi
mailing list