FJEX Fujitsu Function Buttons

Nate Lawson nate at root.org
Mon Nov 8 14:06:32 PST 2004


Anish Mistry wrote:
> On Wednesday 04 August 2004 06:23 pm, Nate Lawson wrote:
> 
>>Anish Mistry wrote:
>>
>>>On Monday 02 August 2004 05:24 pm, Anish Mistry wrote:
>>>
>>>>I've cleaned up the acpi_fuji module.  Please comment on what needs to
>>>>be changed for it to be committed.  Thanks.
>>>>
>>>>http://am-productions.biz/docs/acpi_fjex.tgz
>>>
>>>Wow, I'm a moron.  Correct link:
>>>http://am-productions.biz/docs/acpi_fuji.tgz
>>
>>Thanks for the update.  We'll definitely review it, make comments, etc.
>>  However, no new drivers should be imported before 5.3-RELEASE.  We
>>need to spend time cleaning up existing drivers and bugfixing.
> 
> Now that 5.3 is out the door what do I need to do to get this committed?

Thanks for pinging me.  I'd like to see it match style(9) (i.e. 8 space 
tabs.)  All new code in acpi has done this.  Also, it could use locking 
(serialization would be fine since this code isn't in any fast path). 
Also, I assume you have a script for driving it?

-- 
Nate


More information about the freebsd-acpi mailing list