APM Patch - review

Nate Lawson nate at root.org
Wed May 26 22:08:37 PDT 2004


On Tue, 25 May 2004, Grover, Andrew wrote:
> Valid values for remaining battery life are 0xFF, and 0-100.
>
> -1, 255 and 0xFF are the SAME when looking at an 8 bit value. Since this
> 8 bit value was sign-extended to 32 bits to go into ai_batt_time, if it
> was 0xFF, it is now 0xFFFFFFFF, and you will never see 0x000000FF.

Correct.  Liam, can you add a printf for the unknown case (%x) that gives
the actual value?

-Nate


More information about the freebsd-acpi mailing list