Patch: Defer bus_config_intr() until bus_alloc_resource()..

[Nate Lawson]

On Tue, 1 Jun 2004, John Baldwin wrote:
> I need the patch below in order to turn on bus_config_intr() when using the
> I/O APICs.  The original problem is that the _CRS of link devices is
> configured which is the PIC IRQ and thus screws up intpins when using the
> APIC.  It basically takes bus_config_intr() out of the resource parsing code
> and does the config when an IRQ is allocated via bus_alloc_resource() for
> normal devices, and when a PCI IRQ is routed for PCI link devices.

I appreciate what you're trying to do but I don't like this approach.
Deferring half the parsing to alloc time and moving it from
acpi_resource.c results in a lot of unnecessary duplication and layering
violation.  The real issue you're trying to work around is that you want
to defer the actual config_intr until you're sure which intr you're going
to use.

Some suggestions...  Make polarity and trigger real resource types
(sys/i386/include/resource.h) and do a bus_set_resource of them in the
resource parsing code.  Then in the alloc code do a bus_get_resource for
them and then call BUS_CONFIG_INTR.  Additionally, instead of doing the
deferred BUS_CONFIG_INTR in the alloc code, it should actually be done in
the MD code for bus_setup_intr().  This seems cleaner since allocating an
irq resource shouldn't poke the hw until bus_setup_intr().

-Nate