Panasonic acpi driver

[OGAWA Takaya]

At Sat, 17 Jul 2004 18:35:12 +0900 (JST),
Takahashi Yoshihiro wrote:
> I put new patch to
> http://home.jp.freebsd.org/~nyan/patches/acpi_pana2.diff.gz

Thank you.  That looks great!
It does the job without any problem here.

I'd suggest updating the manual page as attached below.  The patch
contais some documentation error corrections, a couple of
grammartical fixes and a few structural improvements.


--- acpi_panasonic.4.orig	Sun Jul 18 01:57:27 2004
+++ acpi_panasonic.4	Sun Jul 18 03:28:46 2004
@@ -43,7 +43,17 @@
 Toughbook, outside Japan) CF-R1N, CF-R2A and CF-R3.
 It may also work on other models as well.
 .Pp
-On these models there are 9 hotkeys available:
+The driver consists of three functionalities.
+The first is to detect hotkey events and take corresponding actions,
+which include changing LCD luminance and speaker mute state.
+The second role is to notify occurences of the event by way of
+.Xr devctl 4
+and eventually to
+.Xr devd 8 .
+The third and last is to provide a way to adjust LCD brightness and
+sound mute state via sysctl.  
+.Ss Hotkeys
+There are 9 hotkeys available on the supported hardwares:
 .Pp
 .Bl -tag -compact -offset indent
 .It Sy \&Fn+F1
@@ -52,11 +62,11 @@
 Make LCD backlight brighter.
 .It Sy \&Fn+F3
 Switch video output between LCD and CRT.
-Not supported within the
+Not supported by the
 .Nm
 driver.
 .It Sy \&Fn+F4
-Toggle muting a speaker.
+Toggle muting the speaker.
 .It Sy \&Fn+F5
 Turn the mixer volume down.
 .It Sy \&Fn+F6
@@ -69,14 +79,16 @@
 Enter suspend-to-disk state.
 .El
 .Pp
-The driver consists of two functionality.
-The first is to notify the occurence of the hotkey event by way of
-.Xr devctl 4
-and eventually to
-.Xr devd 8 .
-The second role is to provide the way to adjust LCD brightness and
-sound mute state via sysctl.  
-.Sh DEVD EVENTS
+Actions are automatically taken within the driver for
+.Sy \&Fn+F1 ,
+.Sy \&Fn+F2
+and
+.Sy \&Fn+F4 .
+For the other events such as
+mixer control and showing battery status,
+.Xr devd 8
+should take the role as described below.
+.Ss Devd Events
 When notified to
 .Xr devd 8 ,
 the hotkey event provides the following information:
@@ -112,17 +124,18 @@
 and so on.
 .El
 .Sh SYSCTLS
-The following MIBs are available:
-.Bl -tag -offset indent
-.It Sy hw.acpi.panasonic.lcd_brightness_max
+The following read-write MIBs are available:
+.Bl -tag -width indent
+.It Va hw.acpi.panasonic.lcd_brightness_max
 The max level of brightness.
 The value ranges from 0 to 255.
-CF-R1N and CF-R2A should be 255, CF-R3 is 32.
-.It Sy hw.acpi.panasonic.lcd_brightness
+CF-R1N and CF-R2A should be 255, CF-R3 is 31.
+.It Va hw.acpi.panasonic.lcd_brightness
 Current brightness level of the LCD.
-The value ranges from 0 to 15.
-.It Sy hw.acpi.panasonic.sound_mute
-Boolean flag to control whether to mute the speaker.
+The value ranges from 0 to
+.Va hw.acpi.panasonic.lcd_brightness_max .
+.It Va hw.acpi.panasonic.sound_mute
+A boolean flag to control whether to mute the speaker.
 The value 1 means to mute and 0 not.
 .El
 .Sh SEE ALSO

----------
おがわ たかや
t-ogawa at triaez.kaisei.org