git: 6f6cd1e8e8aa - main - ktrace: Remove vrele() at the end of ktr_writerequest()

Mark Johnston markj at FreeBSD.org
Sun May 23 18:13:54 UTC 2021


The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=6f6cd1e8e8aa3a48b35598992f1b6c21003d35cd

commit 6f6cd1e8e8aa3a48b35598992f1b6c21003d35cd
Author:     Mark Johnston <markj at FreeBSD.org>
AuthorDate: 2021-05-23 17:20:05 +0000
Commit:     Mark Johnston <markj at FreeBSD.org>
CommitDate: 2021-05-23 18:13:01 +0000

    ktrace: Remove vrele() at the end of ktr_writerequest()
    
    As of commit fc369a353 we no longer ref the vnode when writing a record.
    Drop the corresponding vrele() call in the error case.
    
    Fixes:  fc369a353 ("ktrace: fix a race between writes and close")
    Reported by:    syzbot+9b96ea7a5ff8917d3fe4 at syzkaller.appspotmail.com
    Reported by:    syzbot+6120ebbb354cd52e5107 at syzkaller.appspotmail.com
    Reviewed by:    kib
    MFC after:      6 days
    Differential Revision:  https://reviews.freebsd.org/D30404
---
 sys/kern/kern_ktrace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/kern/kern_ktrace.c b/sys/kern/kern_ktrace.c
index 3a223215a60d..9059a75f571c 100644
--- a/sys/kern/kern_ktrace.c
+++ b/sys/kern/kern_ktrace.c
@@ -1361,7 +1361,6 @@ ktr_writerequest(struct thread *td, struct ktr_request *req)
 	PROC_UNLOCK(p);
 	ktr_io_params_free(kiop1);
 	ktr_io_params_free(kiop);
-	vrele(vp);
 }
 
 /*


More information about the dev-commits-src-main mailing list