git: 032bf749fd44 - main - [tcp] Keep socket buffer locked until upcall

[Mark Johnston]

On Fri, May 21, 2021 at 09:08:41AM +0000, Richard Scheffenegger wrote:
> The branch main has been updated by rscheff:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=032bf749fd44ac5ff20aab2c3d8e3c05491778ea
> 
> commit 032bf749fd44ac5ff20aab2c3d8e3c05491778ea
> Author:     Richard Scheffenegger <rscheff at FreeBSD.org>
> AuthorDate: 2021-05-21 09:00:53 +0000
> Commit:     Richard Scheffenegger <rscheff at FreeBSD.org>
> CommitDate: 2021-05-21 09:07:51 +0000
> 
>     [tcp] Keep socket buffer locked until upcall
>     
>     r367492 would unlock the socket buffer before eventually calling the upcall.
>     This leads to problematic interaction with NFS kernel server/client components
>     (MP threads) accessing the socket buffer with potentially not correctly updated
>     state.

The RACK change at least appears to have introduced a bug:

https://syzkaller.appspot.com/bug?id=d7abacdaf60c556dbfa05f15f460cd7174e974ba
https://syzkaller.appspot.com/bug?id=650a391473e34b753b280db1c9c97918d23c6cdb