git: 70ffaaa69c83 - main - Update USB_PORT_RESET_RECOVERY to comply with the USB 2.0 specification which says it should be max 10 milliseconds.

Hans Petter Selasky hselasky at FreeBSD.org
Tue May 18 14:16:08 UTC 2021


The branch main has been updated by hselasky:

URL: https://cgit.FreeBSD.org/src/commit/?id=70ffaaa69c830d26b59136d0b0447ab2f8683db8

commit 70ffaaa69c830d26b59136d0b0447ab2f8683db8
Author:     Hans Petter Selasky <hselasky at FreeBSD.org>
AuthorDate: 2021-05-18 13:22:32 +0000
Commit:     Hans Petter Selasky <hselasky at FreeBSD.org>
CommitDate: 2021-05-18 13:52:41 +0000

    Update USB_PORT_RESET_RECOVERY to comply with the USB 2.0 specification which
    says it should be max 10 milliseconds.
    
    This may fix some USB enumeration issues:
    > usbd_req_re_enumerate: addr=3, set address failed! (USB_ERR_IOERROR, ignored)
    > usbd_setup_device_desc: getting device descriptor at addr 3 failed,
    
    Found by:       Zhichao1.Li at dell.com
    MFC after:      1 week
    Sponsored by:   Mellanox Technologies // NVIDIA Networking
---
 sys/dev/usb/usb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/usb/usb.h b/sys/dev/usb/usb.h
index 346ecd3059d7..dcdb62114d63 100644
--- a/sys/dev/usb/usb.h
+++ b/sys/dev/usb/usb.h
@@ -115,7 +115,7 @@ MALLOC_DECLARE(M_USBDEV);
 /* Allow for marginal and non-conforming devices. */
 #define	USB_PORT_RESET_DELAY		50	/* ms */
 #define	USB_PORT_ROOT_RESET_DELAY	200	/* ms */
-#define	USB_PORT_RESET_RECOVERY		250	/* ms */
+#define	USB_PORT_RESET_RECOVERY		10	/* ms */
 #define	USB_PORT_POWERUP_DELAY		300	/* ms */
 #define	USB_PORT_RESUME_DELAY		(20*2)	/* ms */
 #define	USB_SET_ADDRESS_SETTLE		10	/* ms */


More information about the dev-commits-src-main mailing list