git: 687e510e5ce3 - main - netgraph/ng_checksum: Fix double free error
Lutz Donnerhacke
donner at FreeBSD.org
Sun May 16 17:41:34 UTC 2021
The branch main has been updated by donner:
URL: https://cgit.FreeBSD.org/src/commit/?id=687e510e5ce32fddf46a9dc1d517ccc8a8e25581
commit 687e510e5ce32fddf46a9dc1d517ccc8a8e25581
Author: Lutz Donnerhacke <donner at FreeBSD.org>
AuthorDate: 2021-05-15 09:32:57 +0000
Commit: Lutz Donnerhacke <donner at FreeBSD.org>
CommitDate: 2021-05-16 17:39:51 +0000
netgraph/ng_checksum: Fix double free error
m_pullup(9) frees the mbuf(9) chain in the case of an allocation error.
The mbuf chain must not be freed again in this case.
PR: 255874
Submitted by: <lylgood at foxmail.com>
Approved by: markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D30273
---
sys/netgraph/ng_checksum.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/netgraph/ng_checksum.c b/sys/netgraph/ng_checksum.c
index 682375c805da..3b542bd86acc 100644
--- a/sys/netgraph/ng_checksum.c
+++ b/sys/netgraph/ng_checksum.c
@@ -682,9 +682,9 @@ bypass:
return (error);
done:
+ NG_FREE_M(m);
drop:
NG_FREE_ITEM(item);
- NG_FREE_M(m);
priv->stats.dropped++;
More information about the dev-commits-src-main
mailing list