git: effc8e57fbf0 - main - libalias: Style cleanup

[Konstantin Belousov]

On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> On Sat, May 15, 2021 at 10:41:53PM +0300, Konstantin Belousov wrote:
> > On Sat, May 15, 2021 at 07:01:07AM +0000, Lutz Donnerhacke wrote:
> > > @@ -285,21 +283,20 @@ static int	UdpAliasOut(struct libalias *, struct ip *, int, int create);
> > >  static int	TcpAliasIn(struct libalias *, struct ip *);
> > >  static int	TcpAliasOut(struct libalias *, struct ip *, int, int create);
> > >  
> > > -static int
> > > -IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > > -{
> > > -
> > > -	LIBALIAS_LOCK_ASSERT(la);
> > >  /*
> > >      De-alias incoming echo and timestamp replies.
> > >      Alias incoming echo and timestamp requests.
> > >  */
> > > +static int
> > > +IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > > +{
> > > +	LIBALIAS_LOCK_ASSERT(la);
> > >  	struct alias_link *lnk;
> > >  	struct icmp *ic;
> > And this is not in style.  Declarations must precede executable statements,
> > even asserts.
> 
> Of course it was a style commit.
> 
> + /*
> +      De-alias incoming echo and timestamp replies.
> +      Alias incoming echo and timestamp requests.
> +  */
>   static int
>   IcmpAliasIn1(struct libalias *la, struct ip *pip)
>   {
> -
> 	LIBALIAS_LOCK_ASSERT(la);
> - /*
> -      De-alias incoming echo and timestamp replies.
> -      Alias incoming echo and timestamp requests.
> -  */
>  	struct alias_link *lnk;
I do not understand what are you trying to say.