git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2.

[Nathan Whitehorn]

On 3/3/21 9:05 AM, Brandon Bergren wrote:
> On Wed, Mar 3, 2021, at 6:53 AM, Rodney W. Grimes wrote:
>> What am I missing here?  One place I am being told this is run in
>> an environment that may not even be an EFI booted system, and in
>> another place it is being used as a test if something is mounted
>> on it, which should only be true on an EFI booted system.
> That the script in question is a generic script that runs as part of bsdinstall on every platform and has to be universal.
>
> The actual *problem* here is that usr.sbin/bsdinstall/scripts/bootconfig has a default case that is
>              *)          die "Unsupported arch $(uname -m) for UEFI install"
>
> which then causes the main script to bail out, leaving the system in a half-installed state.
>
> If that had just been an exit 0 this would have never been a problem, I suppose.
>
> Before the original change that broke this, there was a check that the script was not running on powerpc or mips platforms before running the efi bits, but this got taken out.
>

Well, incidentally. The bootconfig script needs to know if there is an 
ESP it should configure, but the signalling mechanism (the presence of 
the ESP mount point) was being broken by mtree making that directory 
unconditionally even on systems that don't use EFI. So then bootconfig 
tried to set it up, but failed later on, because there was no EFI loader 
to set up. The mtree change makes the ESP mount point only exist on 
systems with an ESP.
-Nathan