git: 60a38abb8982 - main - pf: Avoid leaking pad bytes in struct pfr_astats when copying out
Mark Johnston
markj at FreeBSD.org
Tue Jun 1 23:51:08 UTC 2021
The branch main has been updated by markj:
URL: https://cgit.FreeBSD.org/src/commit/?id=60a38abb8982e11ee71559057dd7128bd097043e
commit 60a38abb8982e11ee71559057dd7128bd097043e
Author: Mark Johnston <markj at FreeBSD.org>
AuthorDate: 2021-06-01 14:56:23 +0000
Commit: Mark Johnston <markj at FreeBSD.org>
CommitDate: 2021-06-01 23:37:50 +0000
pf: Avoid leaking pad bytes in struct pfr_astats when copying out
There is padding between pfr_astats.pfras_a and pfras_packets that was
not getting initialized.
Reported by: KMSAN
Reviewed by: kp, imp
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D30585
---
sys/netpfil/pf/pf_table.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sys/netpfil/pf/pf_table.c b/sys/netpfil/pf/pf_table.c
index af2f614c9e8c..f643790ff620 100644
--- a/sys/netpfil/pf/pf_table.c
+++ b/sys/netpfil/pf/pf_table.c
@@ -1028,6 +1028,7 @@ pfr_copyout_astats(struct pfr_astats *as, const struct pfr_kentry *ke,
int dir, op;
const struct pfr_kcounters *kc = &ke->pfrke_counters;
+ bzero(as, sizeof(*as));
pfr_copyout_addr(&as->pfras_a, ke);
as->pfras_tzero = kc->pfrkc_tzero;
More information about the dev-commits-src-main
mailing list