git: 16079c7233be - main - hid: quiet -Wswitch

Vladimir Kondratyev vladimir at kondratyev.su
Mon Jan 11 19:15:11 UTC 2021


On 11.01.2021 21:03, John Baldwin wrote:
> On 1/10/21 9:54 PM, Ryan Libby wrote:
>> The branch main has been updated by rlibby:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370
>>
>> commit 16079c7233be8bd6c88e3421a70c7ca87cfea370
>> Author:     Ryan Libby <rlibby at FreeBSD.org>
>> AuthorDate: 2021-01-11 05:53:15 +0000
>> Commit:     Ryan Libby <rlibby at FreeBSD.org>
>> CommitDate: 2021-01-11 05:53:15 +0000
>>
>>     hid: quiet -Wswitch
>>     
>>     Gcc builds complained that not all switch cases are handled.  Add
>>     default cases to appease gcc.
>>     
>>     Reviewed by:    hselasky (previous version), wulf
>>     Sponsored by:   Dell EMC Isilon
>>     Differential Revision:  https://reviews.freebsd.org/D28082
> 
> If these cases are never reachable, then I think '__assert_unreachable()'
> is preferred to a plain break.
> 
These cases are reachable. They are NOP steps of state machine.


More information about the dev-commits-src-main mailing list