git: 8f63fa78e84a - main - rtld: Remove calculate_tls_end

[Konstantin Belousov]

On Mon, Aug 16, 2021 at 09:53:35AM -0700, John Baldwin wrote:
> On 8/16/21 3:56 AM, Konstantin Belousov wrote:
> > The branch main has been updated by kib:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=8f63fa78e84afd23fa68c82eabfe64763c92d4f5
> > 
> > commit 8f63fa78e84afd23fa68c82eabfe64763c92d4f5
> > Author:     Fangrui Song <i at maskray.me>
> > AuthorDate: 2021-08-14 17:02:09 +0000
> > Commit:     Konstantin Belousov <kib at FreeBSD.org>
> > CommitDate: 2021-08-16 10:55:35 +0000
> > 
> >      rtld: Remove calculate_tls_end
> >      Variant I architectures use off and Variant II ones use size + off.
> >      Define TLS_VARIANT_I/TLS_VARIANT_II symbols similarly to how libc
> >      handles it.
> >      Reviewed by:    kib
> >      MFC after:      1 week
> >      Differential revision:  https://reviews.freebsd.org/D31539
> >      Differential revision:  https://reviews.freebsd.org/D31541
> 
> Would it make sense to have <machine/tls.h> and move the TLS-related
> constants there?  Right now we duplicate them in at least two places
> (libthr internal headers and libc/rtld).

This is some slow progress.  Before this commit, we have that in three
places.  Eventually yes, it should be consolidated.