git: d36d68161517 - main - rtld dl_iterate_phdr(): dlpi_tls_data is wrong

[Konstantin Belousov]

On Wed, Apr 07, 2021 at 10:19:51AM +0200, Antoine Brodin wrote:
> On Tue, Apr 6, 2021 at 8:36 PM Jung-uk Kim <jkim at freebsd.org> wrote:
> >
> > On 21. 4. 5., Konstantin Belousov wrote:
> > > The branch main has been updated by kib:
> > >
> > > URL: https://cgit.FreeBSD.org/src/commit/?id=d36d6816151705907393889d661cbfd25c630ca8
> > >
> > > commit d36d6816151705907393889d661cbfd25c630ca8
> > > Author:     Konstantin Belousov <kib at FreeBSD.org>
> > > AuthorDate: 2021-04-05 03:05:44 +0000
> > > Commit:     Konstantin Belousov <kib at FreeBSD.org>
> > > CommitDate: 2021-04-06 00:23:08 +0000
> > >
> > >     rtld dl_iterate_phdr(): dlpi_tls_data is wrong
> > >
> > >     dl_iterate_phdr() dlpi_tls_data should provide the TLS module segment
> > >     address, and not the TLS init segment address as it does now.
> > >
> > >     Reported by:    emacsray at gmail.com
> > >     PR:     254774
> > >     Sponsored by:   The FreeBSD Foundation
> > >     MFC after:      1 week
> >
> > I started having strange hangs in various applications from yesterday,
> > e.g., Xorg, Thunderbird, etc.  Today, I updated ports tree from Git for
> > the first time and started updating packages.  Then, I experienced
> > similar problems, e.g., building editors/kate, multimedia/vlc, etc.,
> > were hanging.  I noticed some tools were stuck in urwlck state and I
> > found reverting this commit fixed the problem for me.
> >
> > Please take a look.
> 
> Hi,
> 
> I don't know if it's related,  but some port builds are hanging with
> b8028f9d3ca0 that didn't happen with 4c2e9c35fb19.

Perhaps this is related.  I did not received the backtrace from the hung
process to say definitely.

The D29623 review is the fix.