An apology about my commits

[Hans Petter Selasky]

On 4/27/21 12:53 AM, Neel Chauhan wrote:
> Hi src committers,
> 
> I hope all is well with you.
> 
> I am really sorry about me prematurely pushing these MFC'ing these 
> linuxkpi commits to stable/13 instead of waiting out the three-day minimum:
> 
> 
> Going forward, I will respect the 3 day waiting period for future src 
> commits.
> 
> I hope you all have a great day.

Hi Neel,

All your patches were solid and reviewed by others and didn't break the 
builds. I would expect that the comments in differential were squashed 
together as a single patch before the commit. I personally use "env 
GIT_EDITOR=ee git rebase -i", and then change the word "pick" into "s" 
for squashing. The 3-day minimum waiting period is more or less to catch 
issues with the patches before they hit -stable branches. Only in rare 
cases I've seen exceptions, but I've never seen anyone loose their 
commit bits over that :-) So don't worry and sleep well. Keep up the 
good work in the LinuxKPI Neel! And if in doubt there are many active 
FreeBSD developers to ask before commit :-)

--HPS


> 
> Thank You,
> 
> Neel Chauhan (nc@)
> _______________________________________________
> dev-commits-src-all at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all
> To unsubscribe, send any mail to 
> "dev-commits-src-all-unsubscribe at freebsd.org"