git: 8393e034dace - stable/13 - cache: temporarily drop the assert that dvp != vp when adding an entry

[Mateusz Guzik]

The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=8393e034dacec0bbafdd470c3cceaecc693357ea

commit 8393e034dacec0bbafdd470c3cceaecc693357ea
Author:     Mateusz Guzik <mjg at FreeBSD.org>
AuthorDate: 2021-02-27 22:23:23 +0000
Commit:     Mateusz Guzik <mjg at FreeBSD.org>
CommitDate: 2021-04-10 14:00:57 +0000

    cache: temporarily drop the assert that dvp != vp when adding an entry
    
    Historically it was allowed for any names, but arguably should never be
    even attempted. Allow it again since there is a release pending and
    allowing it is bug-compatible with previous behavior.
    
    Reported by:    otis
    
    (cherry picked from commit 1239a722214c245e642733fdea2b1348101598af)
---
 sys/kern/vfs_cache.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index b5fa21eea887..8819ef483af5 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -2394,7 +2394,12 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, struct componentname *cnp,
 	KASSERT(cnp->cn_namelen <= NAME_MAX,
 	    ("%s: passed len %ld exceeds NAME_MAX (%d)", __func__, cnp->cn_namelen,
 	    NAME_MAX));
+#ifdef notyet
+	/*
+	 * Not everything doing this is weeded out yet.
+	 */
 	VNPASS(dvp != vp, dvp);
+#endif
 	VNPASS(!VN_IS_DOOMED(dvp), dvp);
 	VNPASS(dvp->v_type != VNON, dvp);
 	if (vp != NULL) {