git: b85a67f54a40 - main - Optimize TX coalescing by keeping pointer to last mbuf.

[Alexander Motin]

The branch main has been updated by mav:

URL: https://cgit.FreeBSD.org/src/commit/?id=b85a67f54a40053e75658a17c620b89bafaba67f

commit b85a67f54a40053e75658a17c620b89bafaba67f
Author:     Alexander Motin <mav at FreeBSD.org>
AuthorDate: 2021-03-02 04:31:34 +0000
Commit:     Alexander Motin <mav at FreeBSD.org>
CommitDate: 2021-03-02 04:34:11 +0000

    Optimize TX coalescing by keeping pointer to last mbuf.
    
    Before m_cat() each time traversed through all the coalesced chain.
    
    MFC after:      1 week
---
 sys/dev/iscsi/icl_soft.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sys/dev/iscsi/icl_soft.c b/sys/dev/iscsi/icl_soft.c
index a5696647169a..c66d8ccdb5fd 100644
--- a/sys/dev/iscsi/icl_soft.c
+++ b/sys/dev/iscsi/icl_soft.c
@@ -849,6 +849,7 @@ static void
 icl_conn_send_pdus(struct icl_conn *ic, struct icl_pdu_stailq *queue)
 {
 	struct icl_pdu *request, *request2;
+	struct mbuf *m;
 	struct socket *so;
 	long available, size, size2;
 	int coalesced, error;
@@ -908,8 +909,8 @@ icl_conn_send_pdus(struct icl_conn *ic, struct icl_pdu_stailq *queue)
 			return;
 		}
 		if (coalesce) {
-			coalesced = 1;
-			for (;;) {
+			m = request->ip_bhs_mbuf;
+			for (coalesced = 1; ; coalesced++) {
 				request2 = STAILQ_FIRST(queue);
 				if (request2 == NULL)
 					break;
@@ -926,13 +927,14 @@ icl_conn_send_pdus(struct icl_conn *ic, struct icl_pdu_stailq *queue)
 					icl_conn_fail(ic);
 					return;
 				}
-				m_cat(request->ip_bhs_mbuf, request2->ip_bhs_mbuf);
+				while (m->m_next)
+					m = m->m_next;
+				m_cat(m, request2->ip_bhs_mbuf);
 				request2->ip_bhs_mbuf = NULL;
 				request->ip_bhs_mbuf->m_pkthdr.len += size2;
 				size += size2;
 				STAILQ_REMOVE_AFTER(queue, request, ip_next);
 				icl_soft_pdu_done(request2, 0);
-				coalesced++;
 			}
 #if 0
 			if (coalesced > 1) {