git: 3f197b101f71 - main - release: Remove C-like string comparison operator

Warner Losh imp at bsdimp.com
Wed Jun 30 18:20:29 UTC 2021


On Wed, Jun 30, 2021 at 11:59 AM Alexey Dokuchaev <danfe at freebsd.org> wrote:

> On Wed, Jun 30, 2021 at 05:20:46PM +0000, Warner Losh wrote:
> > commit 3f197b101f71ee4f4949c53bf330f61b43749ce9
> >
> >     release: Remove C-like string comparison operator
> >
> >     Per [(1), i.e. test(1), the string comparison operator should be `=`,
> >     not `==` in sh(1) scripts.
> >
> >     No functional change. FreeBSD's test accepts `==` as an alias for `=`
> >     for compatibility with gnu test's `==` extension.
>
> Nice, thanks, but why didn't you remove those needless quotes around
> static stings, e.g. "GPT" -> GPT?
>

Sure, that could also be done. However, I'll leave it to the re@ team. It
works
either way, and I've seen both styles in the tree (and outside it  as well).

Warner


More information about the dev-commits-src-all mailing list