git: 292808246db7 - main - ICMP checksum test: Fix for big endian

Ryan Libby rlibby at freebsd.org
Tue Jan 12 03:25:08 UTC 2021


On Mon, Jan 11, 2021 at 6:10 PM Alan Somers <asomers at freebsd.org> wrote:
>
> The branch main has been updated by asomers:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=292808246db702b9194deb8938e40fd06914aea9
>
> commit 292808246db702b9194deb8938e40fd06914aea9
> Author:     Charlie Root <renato.riolino at eldorado.org.br>

Hmm, did your git client fill in the author name that way?  Since...

> AuthorDate: 2021-01-12 01:56:12 +0000
> Commit:     Alan Somers <asomers at FreeBSD.org>
> CommitDate: 2021-01-12 02:03:46 +0000
>
>     ICMP checksum test: Fix for big endian
>
>     The in_cksum tests originally tried to simulate a BE environment by
>     swapping the byte order of the input.  But that's overcomplicated, and
>     didn't actually work on real BE hardware.  The correct testing strategy
>     is just to test on the native endianness, and run the tests in both BE
>     and LE environments.
>
>     Submitted by:           Renato Riolino <renato.riolino at eldorado.org.br>

...given this submitted-by line, I am guessing it wasn't intended?

>     Reviewed By:            asomers
>     MFC after:              2 weeks
>     Differential Revision:  https://reviews.freebsd.org/D23193
> ---


More information about the dev-commits-src-all mailing list