git: 022ca2fc7fe0 - main - Add aio_writev and aio_readv

[Brooks Davis]

On Sat, Jan 02, 2021 at 10:09:04PM -0700, Alan Somers wrote:
> On Sat, Jan 2, 2021 at 9:39 PM Jessica Clarke <jrtc27 at freebsd.org> wrote:
> 
> > On 3 Jan 2021, at 02:59, Alan Somers <asomers at FreeBSD.org> wrote:
> > > diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master
> > > index b7ea5e939635..aaa0a1277461 100644
> > > --- a/sys/kern/syscalls.master
> > > +++ b/sys/kern/syscalls.master
> > > @@ -1477,7 +1477,17 @@
> > >                   _In_opt_ struct sigevent *sig
> > >               );
> > >       }
> > > -258-271      AUE_NULL        UNIMPL  nosys
> > > +258  AUE_AIO_WRITEV  STD {
> > > +             int aio_writev(
> > > +                 _Inout_ struct aiocb *aiocbp
> > > +             );
> > > +     }
> > > +259  AUE_AIO_READV   STD {
> > > +             int aio_readv(
> > > +                 _Inout_ struct aiocb *aiocbp
> > > +             );
> > > +     }
> > > +260-271      AUE_NULL        UNIMPL  nosys
> > > 272   AUE_O_GETDENTS  COMPAT11 {
> > >               int getdents(
> > >                   int fd,
> >
> > Should these not be added to the end?
> >
> > Jess
> >
> 
> Should they be?  I'm not aware of any requirement to add new syscalls to
> the end.  I put them here so they would be next to the other AIO syscalls.

Yes.  I'm sorry I missed this in the review.  It's vastly easier to audit
these files and address conflicts if they are append-only.  We're also
using these syscall numbers internally specifically to avoid conflicts
with new syscalls.  Please move them to the end.

I do see that we only provide extremely outdated advice in the comments
of syscalls.master.  I'll take a look at improving this and the wiki
page.

Thanks,
Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-src-all/attachments/20210105/ad57fa2a/attachment.sig>