git: d7c62d98c9f9 - main - cache: call cache_fplookup_modifying in neg

Mateusz Guzik mjg at FreeBSD.org
Fri Jan 1 00:11:53 UTC 2021


The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=d7c62d98c9f92f6be48562add1400f209b5bcac7

commit d7c62d98c9f92f6be48562add1400f209b5bcac7
Author:     Mateusz Guzik <mjg at FreeBSD.org>
AuthorDate: 2020-12-28 11:22:35 +0000
Commit:     Mateusz Guzik <mjg at FreeBSD.org>
CommitDate: 2021-01-01 00:10:43 +0000

    cache: call cache_fplookup_modifying in neg
    
    Tested by:      pho
---
 sys/kern/vfs_cache.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 49fabc47884d..40cd174e1022 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -4501,12 +4501,8 @@ cache_fplookup_neg(struct cache_fpl *fpl, struct namecache *ncp, uint32_t hash)
 	 * If they want to create an entry we need to replace this one.
 	 */
 	if (__predict_false(fpl->cnp->cn_nameiop != LOOKUP)) {
-		/*
-		 * TODO
-		 * This should call something similar to
-		 * cache_fplookup_final_modifying.
-		 */
-		return (cache_fpl_partial(fpl));
+		fpl->tvp = NULL;
+		return (cache_fplookup_modifying(fpl));
 	}
 	neg_promote = cache_neg_hit_prep(ncp);
 	if (!cache_ncp_canuse(ncp)) {


More information about the dev-commits-src-all mailing list