git: 1de1e2bfbf3c - main - ffs_syncvnode: only clear IN_NEEDSYNC after successfull sync

[Konstantin Belousov]

The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=1de1e2bfbf3c089418bbe67c096d60315c8ca5dd

commit 1de1e2bfbf3c089418bbe67c096d60315c8ca5dd
Author:     Konstantin Belousov <kib at FreeBSD.org>
AuthorDate: 2021-01-23 21:50:55 +0000
Commit:     Konstantin Belousov <kib at FreeBSD.org>
CommitDate: 2021-02-12 01:02:20 +0000

    ffs_syncvnode: only clear IN_NEEDSYNC after successfull sync
    
    If it is cleaned before the sync, other threads might see the inode without
    the flag set, because syncing could unlock it.
    
    Reviewed by:    chs, mckusick
    Tested by:      pho
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation
---
 sys/ufs/ffs/ffs_vnops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/ufs/ffs/ffs_vnops.c b/sys/ufs/ffs/ffs_vnops.c
index 68985d8715f3..be2653e32adc 100644
--- a/sys/ufs/ffs/ffs_vnops.c
+++ b/sys/ufs/ffs/ffs_vnops.c
@@ -257,7 +257,6 @@ ffs_syncvnode(struct vnode *vp, int waitfor, int flags)
 	bool still_dirty, unlocked, wait;
 
 	ip = VTOI(vp);
-	ip->i_flag &= ~IN_NEEDSYNC;
 	bo = &vp->v_bufobj;
 	ump = VFSTOUFS(vp->v_mount);
 
@@ -445,6 +444,8 @@ next:
 	}
 	if (error == 0 && unlocked)
 		error = ERELOOKUP;
+	if (error == 0)
+		ip->i_flag &= ~IN_NEEDSYNC;
 	return (error);
 }