git: 4d0dc60f1401 - main - xinstall: fix invocation of llvm-strip

[Ed Maste]

On Mon, 30 Aug 2021 at 10:57, Mitchell Horne <mhorne at freebsd.org> wrote:
>
> The branch main has been updated by mhorne:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02
>
> commit 4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02
> Author:     Mitchell Horne <mhorne at FreeBSD.org>
> AuthorDate: 2021-06-02 15:00:56 +0000
> Commit:     Mitchell Horne <mhorne at FreeBSD.org>
> CommitDate: 2021-08-30 14:56:10 +0000
>
>     xinstall: fix invocation of llvm-strip
>
>     When executing strip(1), '--' is passed as an argument to explicitly
>     terminate the getopt(3) loop. The option parsing in llvm-strip doesn't
>     support this however, so setting XSTRIPBIN=llvm-strip results in an
>     unsupported argument error. llvm-strip(1) is otherwise
>     commandline-compatible with FreeBSD's strip(1), so just use the
>     documented argument format that is common to both.

GNU strip also handles --, so ideally we'd have llvm-strip also accept
it. Given plans to switch to the LLVM version of various binutils
(D31060) we should aim for as complete command-line compatibility as
possible. I've added a note to this effect in D31060.