git: 70a137b75e14 - stable/12 - Do not expose to scheduler caches of single CPU.
Alexander Motin
mav at FreeBSD.org
Wed Aug 11 00:49:58 UTC 2021
The branch stable/12 has been updated by mav:
URL: https://cgit.FreeBSD.org/src/commit/?id=70a137b75e149611c101cb57e0322e370f669094
commit 70a137b75e149611c101cb57e0322e370f669094
Author: Alexander Motin <mav at FreeBSD.org>
AuthorDate: 2021-07-28 20:15:43 +0000
Commit: Alexander Motin <mav at FreeBSD.org>
CommitDate: 2021-08-11 00:49:48 +0000
Do not expose to scheduler caches of single CPU.
Before this change my dual-Xeon(R) Gold 6242R always reported 3 levels
or topology (root, package/L3 and core/L2). But with SMT disabled
core/L2 matches thread, so additional topology level only causes more
traversal work. With this change SMT case is reported same as before,
while non-SMT is reported with only 2 much more simple levels.
MFC after: 2 weeks
(cherry picked from commit 5a49f1914178c5275105f2ab0d23a98118cd585f)
---
sys/x86/x86/mp_x86.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sys/x86/x86/mp_x86.c b/sys/x86/x86/mp_x86.c
index 984edb43dd22..73565360007b 100644
--- a/sys/x86/x86/mp_x86.c
+++ b/sys/x86/x86/mp_x86.c
@@ -817,6 +817,12 @@ x86topo_add_sched_group(struct topo_node *root, struct cpu_group *cg_root)
node = topo_next_nonchild_node(root, node);
}
+ /*
+ * We are not interested in nodes including only one CPU each.
+ */
+ if (nchildren == root->cpu_count)
+ return;
+
cg_root->cg_child = smp_topo_alloc(nchildren);
cg_root->cg_children = nchildren;
More information about the dev-commits-src-all
mailing list