0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9)

[Warner Losh]

On Tue, Apr 27, 2021, 7:30 PM Ravi Pokala <rpokala at freebsd.org> wrote:

> -----Original Message-----
> From: Baptiste Daroussin <bapt at FreeBSD.org>
> Date: 2021-04-27, Tuesday at 00:05
> To: Ravi Pokala <rpokala at freebsd.org>
> Cc: <src-committers at FreeBSD.org>, <dev-commits-src-all at FreeBSD.org>,
> <dev-commits-src-main at FreeBSD.org>
> Subject: Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of
> sbuf(9)
>
>     On Mon, Apr 26, 2021 at 09:13:53PM -0700, Ravi Pokala wrote:
>     > -----Original Message-----
> ...
>     > Hi Baptiste,
>     >
>     >         pw(8): use openmemstream instead of sbuf(9)
>     >
>     > That's the "what", but what's the "why"?
>     >
>     > Thanks,
>     >
>     You are right about this. Here the why. I have been the one
> introducing sbug in
>     pw(8) when I rewrote it, but since the beginning while I found this
> was better
>     than the solution in place I didn't like adding another external lib
> just for
>     that.
>
> Fair enough.
>
>     Short after I discovered about open_memstream(3) and figured it could
> fill the
>     same spot here but keeping the dep only on libc.
>
> I keep forgetting that open_memstream(3) is even a thing. `grep'ing the
> src tree, it looks like it's very rarely used.
>
>     I was puzzled about pushing
>     this change, and the switch to git reminded me about some uncommit
> patches
>     sitting on my tree and I ended up pushing it.
>
>     If people have strong opinion I can revert it back.
>
> I can't imagine anyone having a problem with this. :-)
>

Great explanation. Makes sense to me that you'd want to use a more standard
way of doing this.

Warner


Thanks for explaining.
>
> -Ravi (rpokala@)
>
>     Things that have not been taken in account in the change, but to answer
>     questions asked privately:
>
>     - I have performed absolutely no performance benchmark, it does not
> matter here.
>
>     - The size of the final binary is smaller:
>       - 76k on amd64 for the new version
>       - 77k for the old version
>
>     Best regards,
>     Bapt
>
>
>