git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()

Neel Chauhan nc at freebsd.org
Mon Apr 26 16:51:58 UTC 2021


On 2021-04-26 09:47, Kevin Bowling wrote:
> I'm not sure all the context or conversation here but the convention
> is to not use bare return values, i.e in style(9) "Values in return
> statements should be enclosed in parentheses." and that's what was
> asked to be changed on this mailing list.

The review: https://reviews.freebsd.org/D29988

I believe I was asked to do this in the review.

-Neel
> 
> Can you use and link to Phabricator for your src commits?  As much as
> possible it is preferable to get it right in one go, for MFCs,
> bisection, etc and this kind of churn should be preventable with quick
> reviews.  Feel free to tag me as a reviewer.

Sure, will do next time.


> Regards,
> Kevin

-Neel


More information about the dev-commits-src-all mailing list