git: 44f3b1aa980e - main - rc: kldxref only needs to depend on rootfs, not FILESYSTEMS

[Cy Schubert]

In message <CANCZdfqTTZHMiinT4cvxExkZntzrJrBxd8MbxCJGpnmGwgA-ag at mail.gmail.c
om>
, Warner Losh writes:
> --000000000000e89f2905bf9fcabb
> Content-Type: text/plain; charset="UTF-8"
> Content-Transfer-Encoding: quoted-printable
>
> On Sat, Apr 10, 2021, 8:23 AM T=C4=B3l Coosemans <tijl at freebsd.org> wrote:
>
> > On Sat, 10 Apr 2021 08:32:44 GMT Edward Tomasz Napierala
> > <trasz at FreeBSD.org> wrote:
> > > The branch main has been updated by trasz:
> > >
> > > URL:
> > https://cgit.FreeBSD.org/src/commit/?id=3D44f3b1aa980e747ce9b72ba4333c80a=
> 99d8cd966
> > >
> > > commit 44f3b1aa980e747ce9b72ba4333c80a99d8cd966
> > > Author:     Edward Tomasz Napierala <trasz at FreeBSD.org>
> > > AuthorDate: 2021-04-10 08:19:25 +0000
> > > Commit:     Edward Tomasz Napierala <trasz at FreeBSD.org>
> > > CommitDate: 2021-04-10 08:31:12 +0000
> > >
> > >     rc: kldxref only needs to depend on rootfs, not FILESYSTEMS
> > >
> > >     This makes it run a bit earlier in the startup, which will
> > >     be useful for the linux rc script later on.
> > >
> > >     Reviewed By:    imp (earlier version)
> > >     Sponsored By:   EPSRC
> > >     Differential Revision:  https://reviews.freebsd.org/D29589
> > > ---
> > >  libexec/rc/rc.d/kldxref | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libexec/rc/rc.d/kldxref b/libexec/rc/rc.d/kldxref
> > > index 4d232ee0d4cf..4c1fa15f2a35 100755
> > > --- a/libexec/rc/rc.d/kldxref
> > > +++ b/libexec/rc/rc.d/kldxref
> > > @@ -4,7 +4,7 @@
> > >  #
> > >
> > >  # PROVIDE: kldxref
> > > -# REQUIRE: FILESYSTEMS
> > > +# REQUIRE: root
> > >  # BEFORE:  netif
> > >  # KEYWORD: nojail
> > >
> >
> > kldxref is in /usr which may be a separate file system so this requires
> > at least mountcritlocal.
> >
>
> I'd forgotten that detail. Maybe we should move it there.

This makes a lot more sense because systems that NFS mount /usr may still 
break if the dependency is mountcritlocal.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy at nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.