git: 5061d5a0cfaf - stable/12 - mount_nullfs: rename a local variable

Alan Somers asomers at freebsd.org
Thu Apr 8 22:19:23 UTC 2021


On Thu, Apr 8, 2021 at 3:34 PM Alan Somers <asomers at freebsd.org> wrote:

> The branch stable/12 has been updated by asomers:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1
>
> commit 5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1
> Author:     Alan Somers <asomers at FreeBSD.org>
> AuthorDate: 2021-02-12 18:30:52 +0000
> Commit:     Alan Somers <asomers at FreeBSD.org>
> CommitDate: 2021-04-08 21:32:55 +0000
>
>     mount_nullfs: rename a local variable
>
>     The "source" variable was introduced in r26072, probably as the
>     traditional counterpart to "target".  But the "source"/"target" names
>     suggest the opposite of their actual meaning.  With ln, for example,
> the
>     source is the real file and the target is the newly created link.  In
>     mount_nullfs the meaning is the opposite: the target is the existing
>     file system and the source is the newly created mountpoint.  Better to
>     use "target"/"mountpoint" terminology, which matches the man page.
>
>     Sponsored by:   Axcient
>
>     (cherry picked from commit f540cb27a23719d88b7e5143be6e62f75dd25f08)
>

Oops, this broke the build.  I did a build test, but forgot to check that
the build actually passed.  I'll fix it shortly.
-Alan


More information about the dev-commits-src-all mailing list