git: ee938b20335d - main - kern: efirt: correct configuration table entry size

Jessica Clarke jrtc27 at freebsd.org
Tue Dec 29 17:48:28 UTC 2020


On 29 Dec 2020, at 17:39, Kyle Evans <kevans at FreeBSD.org> wrote:
> diff --git a/sys/sys/efi.h b/sys/sys/efi.h
> index b9f31454efff..220509853cb2 100644
> --- a/sys/sys/efi.h
> +++ b/sys/sys/efi.h
> @@ -52,7 +52,7 @@ typedef unsigned long efi_status;
> 
> struct efi_cfgtbl {
> 	struct uuid	ct_uuid;
> -	uint64_t	ct_data;
> +	void		*ct_data;

Hm, this should probably be a u_long/vm_offset_t/vm_paddr_t (though the
tables are unlikely to be in places where you need PAE so even if
technically correct, vm_paddr_t probably just makes things more awkward
for no gain) given it's not a real pointer that can be dereferenced.

Jess



More information about the dev-commits-src-all mailing list