git: 5d304c338aba - main - games/fheroes2: update to 0.9.4

[Piotr Kubaj]

On 21-06-04 10:06:18, Alexey Dokuchaev wrote:
> On Fri, Jun 04, 2021 at 09:53:37AM +0000, Piotr Kubaj wrote:
> > commit 5d304c338abaef672b8392ff2d2d0b554106950c
> > 
> >     games/fheroes2: update to 0.9.4
> >     
> > @@ -8,20 +8,15 @@ COMMENT=	Free implementation of Heroes of Might and Magic II engine
> >  LICENSE=	GPLv2
> >  LICENSE_FILE=	${WRKSRC}/LICENSE
> >  
> > -LIB_DEPENDS=	libtinyxml.so:textproc/tinyxml
> > +LIB_DEPENDS=	libpng16.so:graphics/png
> 
> It should be spelled as ``libpng.so:graphics/png'', without 16.
Thanks for info.

> 
> > -LDFLAGS+=	-ltinyxml
> > -MAKE_ENV=	WITHOUT_BUNDLED_LIBS=1
> 
> So, what happened to TinyXML dependency?  Is it no longer needed,
> or bundled version is used now for some reason?  This wasn't
> mentioned in the commit log.
The bundled one is used, port switched to cmake, which uses pkgconfig for tinyxml detection, but tinyxml doesn't provide a pc file for pkgconfig, so that fails.


> 
> > +PLIST_FILES=	bin/${PORTNAME} \
> > +		${DOCSDIR}/README.txt \
> > +		${DOCSDIR}/changelog.txt
Thanks for info.

> 
> Docfiles should probably be listed as PORTDOCS, not be part of
> the PLIST_FILES.
> 
> ./danfe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210604/21c7c5b4/attachment.sig>