git: f1e718499cb3 - main - www/civetweb: New port: Embedded C/C++ web server

[Alexey Dokuchaev]

On Wed, Jun 02, 2021 at 02:18:50AM +0000, Guangyuan Yang wrote:
> commit f1e718499cb309115b622453026bbacc4af60d73
> 
>     www/civetweb: New port: Embedded C/C++ web server
>     
>     PR:             255974
>     Approved by:    lwhsu (mentor)

Looks like it was not thorougly reviewed prior to approval.

> ...
> --- /dev/null
> +++ b/www/civetweb/Makefile
> @@ -0,0 +1,21 @@
> +# Created by: maintainer.freebsd at xpoundit.com
> +
> +PORTNAME=	civetweb
> +DISTVERSIONPREFIX=	v
> +DISTVERSION=	1.14
> +CATEGORIES=	www
> +
> +MAINTAINER=	maintainer.freebsd at xpoundit.com
> +COMMENT=	Embedded C/C++ web server

This text makes a nice COMMENT, ...

> --- /dev/null
> +++ b/www/civetweb/pkg-descr
> @@ -0,0 +1,3 @@
> +Embedded C/C++ web server
> +
> +WWW: https://github.com/civetweb/civetweb

... but very bad port description.  It should not be the same as COMMENT
verbatim.  I should also terminate with a full stop (period).  Please
(re)read the PHB Section 3.2.1 on how a good pkg-descr file should look
like.  (Your mentor should have told you this.)

./danfe