git: e497a16a2869 - main - ports-mgmt/pkg*: Release 1.17.0

[Bryan Drewery]

On 7/24/21 11:11 PM, Matthias Fechner wrote:
> Am 24.07.2021 um 22:35 schrieb Bryan Drewery:
>> I love the idea here but can this be reverted for now please? Poudriere
>> is not prepared for a default PKG_EXT change.
>>
>> 1. Now that it finds a new PKG_EXT of .pkg, it cannot find the existing
>> bootstrap pkg.txz because it looks for Latest/pkg.pkg ->
>> ../All/pkg-*.pkg even though the *existing* one is .txz. I'm not sure
>> how this symlink is added before pkg is even built but it's not done in
>> a compatible way.
>>
>> 2. The new PKG_EXT makes Poudriere now find no existing packages so
>> everything is rebuilt. Not a deal breaker in itself but a problem for
>> future builds...
>>
>> 3. The rebuild won't remove all the .txz files. I assume once `pkg repo`
>> runs it will find both .txz and .pkg files and cause duplicate version
>> problems in `pkg repo`
>>
>> I see something creates a .txz -> .pkg symlink. What deles that symlink
>> if Poudriere only deletes/rebuilds the .pkg?
>>
>> ***
>> "all those .txz entries are actually _duplicates_ in packagesite.yaml"
>> seen on IRC just now by someone.
>> I can confirm that looking in a packagesite.yaml I just generated. Both
>> the older .txz version of a port and a new revision-bumped one appear in
>> the yaml.
>> ***
>>
>> 4. I've seen reports of packagesite.pkg which is concerning because
>> Poudriere manages packagesite.txz with its own symlinks for
>> hardlink-copied repositories. It does not use PKG_EXT there as they
>> weren't packages, but I suspect we need special handling even with
>> PKG_EXT added there.
>>
> I do not have a fancy setup.
> I rolled yesterday updates to all FreeBSD servers I maintain and saw no
> problem.
> 
> Poudriere was rebuilding all packages, I use on my build server:
> cd /usr/local/etc/poudriere.d/ && poudriere bulk -t -j 130amd64 -f pkglist
> cd /usr/local/etc/poudriere.d/ && poudriere pkgclean -y -j 130amd64 -f
> pkglist

pkgclean avoids the problem by deleting the extra .txz files and
rebuilding the repo.

> 
> While upgrading the servers itself, I upgraded first pkg and then all
> other packages as usual.
> All updates were nicely installed.
> 
> So I do not really understand what you are complaining here for pkg
> 1.17.0 upgrade.
> 
> Gruß
> Matthias
> 


-- 
Regards,
Bryan Drewery