git: 8c256a205fa0 - main - benchmarks/kdiskmark: the port had been updated (+)

[Alexey Dokuchaev]

On Fri, Jul 23, 2021 at 01:33:57PM +0200, Emmanuel Vadot wrote:
> On Fri, 23 Jul 2021 11:28:23 +0000 Alexey Dokuchaev wrote:
> 
> > On Fri, Jul 23, 2021 at 01:24:50PM +0200, Emmanuel Vadot wrote:
> > > On Fri, 23 Jul 2021 11:17:12 GMT
> > > Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> > > > 
> > > >     benchmarks/kdiskmark: the port had been updated (+)
> > > >     
> > > >     - Update KDiskMark to version 2.2.1
> > > 
> > >  Is it that hard for you to put in the first line
> > > "benchmarks/kdiskmark: update to version 2.2.1" ???
> > 
> > I do that if that's the only change in the commit.  This time it
> > was not, there were other changes documented in the commit log,
> 
> benchmarks/kdiskmark: update to version 2.2.1
> While here : 
>   - Make cache clearing and KDE dependency optional
>   - Amend port description and add pkg-help file
> 
> There, I've fixed it for you.

This would imply that update is the main change which is not always
the case.  In general, splitting the bullet list of N items into
1 subject + N-1 items looks a bit ugly.  Also, "cat/port: update ..."
sounds less grammatically incorrect than when using passive voice.

> > so the first line should be ignored (it is marked with plus sign
> > for that reason).
> 
> The first line is the mail subject message and what shown in git log
> --onleline so it needs to contain proper info and not something that
> should be ignored.

It does contain proper info, just not very detailed one, which is not
very important for --onleline format anyway.

./danfe