git: be86c4fe23e0 - main - misc/qtchooser: remove

[Mathieu Arnold]

On Mon, Jul 05, 2021 at 09:08:15AM +0200, Loïc Bartoletti wrote:
> Hello,
> 
> Le 04/07/2021 à 23:28, Christoph Moench-Tegeder a écrit :
> > ## Loïc Bartoletti (lbartoletti at FreeBSD.org):
> > This:
> > 
> > >      misc/qtchooser: remove
> > Does more than it says on the label:
> Indeed, removing a tool like this one cannot be done without patching (many)
> other ports.
> > 
> > > --- a/cad/freecad/Makefile
> > > +++ b/cad/freecad/Makefile
> > > -USES=		dos2unix compiler:c++11-lib cmake gl eigen:3 fortran jpeg \
> > > +USES=		dos2unix compiler:c++17-lang cmake gl eigen:3 fortran jpeg \
> > > +		-DBUILD_ENABLE_CXX_STD=C++17
> Sorry, this line is not needed to build cad/freecad without qtchooser.
> 
> I added it during my tests, because I saw that it was necessary to reduce
> some warnings, but it's not useful for this change.
> 
> > I'd appricate knowing why these additional changes happen - it reduces
> > annoyances on my side when these changes interfere with other patches
> > I've lined up (yeah, I should just commit faster, but sometimes live
> > happens).
> 
> We have communicated in the past, publicly or directly with those affected,
> like you, for this kind of improvement.
> 
> Although this initiative has been public for several months, it may not have
> been visible.
> 
> I will ensure better communication for the next times.

I think the problem Christoph is pointing out is that the commit says
"remove misc/qtchooser" and you are changing which compiler is needed in
cad/freecad, which has absolutely nothing to do with removing
misc/qtchooser.

It is either a mistake and should not have been committed, or it should
have been committed in a separate commit, that would say why you are
changing the compiler needed.
Also, it feels like you're trying to commit stuff under the hood hoping
nobody will notice.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210707/20fdf8a1/attachment.sig>