git: 4f4e43a4a0f4 - main - New port: regather is an LDAP syncrepl consumer which can perform various actions based on LDAP syncrepl events.

[Michael Gmelin]

On Tue, 27 Apr 2021 12:34:08 +0200
Mathieu Arnold <mat at freebsd.org> wrote:

> On Tue, Apr 27, 2021 at 12:03:01PM +0200, Michael Gmelin wrote:
> > 
> > 
> > On Mon, 26 Apr 2021 15:19:04 +0200
> > Mathieu Arnold <mat at freebsd.org> wrote:
> >   
> > > On Mon, Apr 26, 2021 at 09:30:57PM +1000, Kubilay Kocak wrote:  
> > > > On 26/04/2021 9:18 pm, Alexey Dokuchaev wrote:    
> > > > > The branch main has been updated by danfe:
> > > > > 
> > > > > URL:
> > > > > https://cgit.FreeBSD.org/ports/commit/?id=4f4e43a4a0f4350b433a83143824031cb0af043a
> > > > > 
> > > > > commit 4f4e43a4a0f4350b433a83143824031cb0af043a
> > > > > Author:     Alexey Dokuchaev <danfe at FreeBSD.org>
> > > > > AuthorDate: 2021-04-26 11:15:16 +0000
> > > > > Commit:     Alexey Dokuchaev <danfe at FreeBSD.org>
> > > > > CommitDate: 2021-04-26 11:16:56 +0000
> > > > > 
> > > > >      New port: regather is an LDAP syncrepl consumer which can
> > > > > perform various actions based on LDAP syncrepl events.    
> > > > 
> > > > Hey Alexey :)
> > > > 
> > > > Any chance of:
> > > > 
> > > > <title-less-than-75-chars-prefixed-with-component:>    
> > > 
> > > The first line of a commit message should not be longer than 50
> > > columns.  
> > 
> > When applied as a strict rule, this clashes with the "prefix with
> > category/name" requirement.  
> 
> Well, no, the rule is simple, the first line should not be longer than
> 50 chars, and it has to start with with `cat/name:`.
> 
> It is true that for a port like
> security/p5-Dancer2-Plugin-Auth-Extensible-Provider-Usergroup, it gets
> hard so stay below 50.

Even for shorter port origins it can get a bit annoying, as you only
have 50 - strlen(category + "/" + portname + ": ") chars available to
express *what* has changed. This means that we have on average less
than 30 chars available, for about 4000 ports it's 20 chars or less
(which doesn't even fit "Update to latest version" as a commit subject
line).

I'm both a fan of the 50 chars rule, as well as of prefixing with
category/portname - it would be cool to give committers some sort of
(automatically checkable) advise on how to compromise in these cases -
e.g., leave out the category, shorten the port name, or simply relax
the "first line of commit message" rule for ports (src and doc
shouldn't have problems following 50 chars anyway).

Alternatively, limit the length of new ports names accepted into the
framework and rename older ones when they're touched anyway (sounds
painful and a lot of work though). Shorter port origins could be
beneficial in many places though, not just in git commits.

Best,
Michael

-- 
Michael Gmelin