git: 5b7c17856512 - main - git hooks: Rework authorship instructions.
Matthias Andree
mandree at FreeBSD.org
Fri Apr 23 21:53:26 UTC 2021
Am 22.04.21 um 13:23 schrieb Gleb Popov:
>
>
> On Thu, Apr 22, 2021 at 1:49 PM Mathieu Arnold <mat at freebsd.org
> <mailto:mat at freebsd.org>> wrote:
>
> Then you are misusing Submitted by. Submitted by was supposed to be
> used when you committed something that was, well, submitted by someone
> else. If the work is yours, and that you based your work on someone
> else's, then, it is not submitted by them.
>
> --
> Mathieu Arnold
>
>
> In the past I sometimes used "Submitted by (someguy, initial patch)" and
> still think it is a good thing.
>
> Creating an initial port is not only about typing something in the text
> editor, but also figuring out how to build the software. This is also
> quite an effort sometimes, invisible for the commiter, and I believe it
> should be credited.
I concur, and I will pull out something that was proposed between the
lines in this thread already:
1. use the original patch and commit with --author attribution. Do not
push yet.
2. polish, touch-up, refine it as committer or integrator, and commit
that with author = committer
3. git pull --rebase --autostash, git push
4. optionally, MFH
More information about the dev-commits-ports-all
mailing list