git: 5b7c17856512 - main - git hooks: Rework authorship instructions.

[Michael Gmelin]

> On 22. Apr 2021, at 12:49, Mathieu Arnold <mat at freebsd.org> wrote:
> 
> On Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote:
>>> On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote:
>>> On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote:
>>>> ...
>>>> I agree that author should only be used if a submission is applied
>>>> unaltered (pull request/git patch).
>>> 
>>> Submitted by has always been for submission that was unaltered (or only
>>> slightly altered) if it was only the basis of the work, then "submitted
>>> by" is not to be used, in those cases, reported by is the correct
>>> choice.
>> 
>> Not really, no.  "PR:/Submitted by:" is canonical combination, yet most
>> of us modify submitted patches because they almost always need more work.
> 
> Then you are misusing Submitted by.  Submitted by was supposed to be
> used when you committed something that was, well, submitted by someone
> else.  If the work is yours, and that you based your work on someone
> else's, then, it is not submitted by them.
> 

I don’t think git author should be used if anything is altered, including the commit message (as a contributor, I wouldn’t want to give anyone the impression that the rude ramblings of a grumpy committer are to be attributed to me). That doesn’t map well to our model though. I assume the git working group discussed this in detail, especially when it comes to accepting pull requests over various channels.

-m


> -- 
> Mathieu Arnold