git: 3d55eddff7e1 - main - www/xshttpd*: Remove from tree

[Mathieu Arnold]

Hi,

On Tue, Apr 13, 2021 at 09:21:49AM -0700, Kevin Bowling wrote:
> Take a look in the referened PR 254750, the MOVED file also contains
> details.  The gist is, it probably shouldn't have been brought back
> into the tree as it is abandoned, but was and then remained broken for
> over two years.

No.

The commit message MUST state first and foremost the reason (aka the
why) behind the commit.

The what can be seen by looking at the diff, the what SHOULD be
explained (and I say explained, not just translate the diff to english)
in the commit message if the reason behind a bit of change is not
clearly explained by the why.

Extra information if available in a PR for example MAY (note, I said
MAY, not SHOULD or MUST) be left out and an interested party can go look
the PR or whatever other reference was made available in the commit
message.

In this example, the commit message could have started a bit like this:

	www/xshttpd*: Remove abondonware & unfetchable


And then there may have been another paragraph expanding on the reason
behind the removal, for example something like this:

	No new upstream release for the past 10 years, distfile not fetchable,
	and website returns 404.


> On Mon, Apr 12, 2021 at 12:23 PM Jochen Neumeister <joneum at freebsd.org> wrote:
> >
> >
> > Am 12.04.21 um 21:11 schrieb Kevin Bowling:
> > > The branch main has been updated by kbowling:
> > >
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3d55eddff7e1761575e29e946d384ad42eca3067
> > >
> > > commit 3d55eddff7e1761575e29e946d384ad42eca3067
> > > Author:     Kevin Bowling <kbowling at FreeBSD.org>
> > > AuthorDate: 2021-04-12 19:08:44 +0000
> > > Commit:     Kevin Bowling <kbowling at FreeBSD.org>
> > > CommitDate: 2021-04-12 19:10:53 +0000
> > >
> > >      www/xshttpd*: Remove from tree
> > >
> > >      PR:             254750
> > >      Reported by:    daniel.engberg.lists at pyret.net
> >
> >
> > Hi,
> >
> > it would be good if you also wrote why the port was removed.
> >
> >
> > Greetings
> > Jochen
> >
> >
> > > ---
> > >   MOVED                                     |  2 +
> > >   www/Makefile                              |  2 -
> > >   www/xshttpd-devel/Makefile                | 64 ---------------------
> > >   www/xshttpd-devel/distinfo                |  2 -
> > >   www/xshttpd-devel/files/patch-src_extra.c | 34 -----------
> > >   www/xshttpd-devel/files/patch-src_httpd.c | 10 ----
> > >   www/xshttpd-devel/files/patch-src_ssl.c   | 32 -----------
> > >   www/xshttpd-devel/files/xshttpd.in        | 28 ---------
> > >   www/xshttpd-devel/pkg-descr               |  9 ---
> > >   www/xshttpd-devel/pkg-plist               | 94 -------------------------------
> > >   www/xshttpd/Makefile                      | 66 ----------------------
> > >   www/xshttpd/distinfo                      |  2 -
> > >   www/xshttpd/files/patch-src_httpd.c       | 11 ----
> > >   www/xshttpd/files/patch-src_ssl.c         | 14 -----
> > >   www/xshttpd/files/xshttpd.in              | 28 ---------
> > >   www/xshttpd/pkg-descr                     | 23 --------
> > >   www/xshttpd/pkg-plist                     | 84 ---------------------------
> > >   17 files changed, 2 insertions(+), 503 deletions(-)
> > >
> > (snip)
> 

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210414/e3ab9b0f/attachment.sig>