git: c6093a753e76 - main - databases/mysql55-server: fix check-plist

[Adriaan de Groot]

On Friday, 9 April 2021 23:50:07 CEST Gerald Pfeifer wrote:
> On Fri, 9 Apr 2021, Adriaan de Groot wrote:
> >     databases/mysql55-server: fix check-plist
> >     
> >     An empty directory `info` is created during install; it's
> >     not listed in the plist. Get rid of it.
> 
> Is it possible this ...
> 
> > +post-install:
> > +	# Empty directory, but check-plist complains
> > +	@${RMDIR} ${STAGEDIR}${PREFIX}/info || ${TRUE}
> 
> ... is papering over the real issue?

It is definitely paper-thin.

> Then, looking a bit more: Is this port even dealing with .info files
> at all?

No. Omitting the CMake argument changes the problem to "now there is an 
orphaned directory docs/". I suppose I *could* make it point somewhere that 
already exists, and then drop the post-install papering -- I'd prefer it if 
ale@ (maintainer, CC'ed) made that call, though: my primary concern is to deal 
simple with all the package-build failures that occur *before* upgrading 
CMake.

> What happens if you simply omit -DINSTALL_INFODIR="info" ?
> 
> Or make it point to another, existing directory (such as "share")?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210411/2dda3b97/attachment.sig>