git: 8d6cf88d2f - main - committers-guide: Add note to check for default anonymous github names

[Warner Losh]

The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/doc/commit/?id=8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4

commit 8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4
Author:     Warner Losh <imp at FreeBSD.org>
AuthorDate: 2021-06-16 22:14:34 +0000
Commit:     Warner Losh <imp at FreeBSD.org>
CommitDate: 2021-06-16 22:14:34 +0000

    committers-guide: Add note to check for default anonymous github names
    
    Github generates names like
            github-user <38923459+github-user at users.noreply.github.com>
    for it's web-created content. Add a note for people doing pull requests
    to check for this construct and to request a real name.
    
    Sponsored by:           Netflix
---
 .../content/en/articles/committers-guide/_index.adoc          | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc
index 9998694e0f..fffc6ef128 100644
--- a/documentation/content/en/articles/committers-guide/_index.adoc
+++ b/documentation/content/en/articles/committers-guide/_index.adoc
@@ -2329,6 +2329,17 @@ However, when there's multiple commits, especially when minor adjustments are ne
 Briefly, these commands create a branch; cherry-picks the changes from the pull request; tests it; adjusts the commit messages; and fast forward merges it back to `main`.
 The PR number is `$PR` below.
 When adjusting the message, add `Pull Request: https://github.com/freebsd-src/pull/$PR`.
+[NOTE]
+======
+In addition, please check to make sure that the pull request author name is not anonymous.
+Github's web interface generates names like:
+[source,shell]
+....
+Author:     github-user <38923459+github-user at users.noreply.github.com>
+....
+A polite request to the author for a better name and/or email should be made.
+======
+
 [source,shell]
 ....
 % git fetch github pull/$PR/head:staging