cvs commit: src/sbin/ifconfig ifconfig.c

[Sam Leffler]

John Hay wrote:
> On Thu, Oct 02, 2008 at 02:25:11PM +0200, Ed Schouten wrote:
>   
>> Hello Sam,
>>
>> * Sam Leffler <sam at FreeBSD.org> wrote:
>>     
>>> sam         2008-09-29 16:27:32 UTC
>>>
>>>   FreeBSD src repository
>>>
>>>   Modified files:
>>>     sbin/ifconfig        ifconfig.c 
>>>   Log:
>>>   SVN rev 183466 on 2008-09-29 16:27:32Z by sam
>>>   
>>>   Distinguish between cmd/parameters used for clone operations and
>>>   all others.  Use this to disambiguate cmd line arguments that can
>>>   be either clone params or regular parameters so, in particular,
>>>   "bssid" again works as a regular parameter.
>>>   
>>>   While here leverage the above to improve the logic for flushing
>>>   clone operations on the first !clone cmd line parameter.
>>>   
>>>   Reviewed by:    jhay
>>>       
>> Is it possible that this commit broke `ifconfig foo vlan bar vlandev baz'?
>> I just had to revert to an ifconfig, probably from September 22, to make
>> my system work properly again.
>>     
>
> And if you try with "ifconfig foo create vlan bar vlandev baz"? I have
> only tried it with the create keyword added and the clone stuff in
> /etc/network.subr also use it like that, if I read the code correctly.
> I think if it previously worked, it was by accident. :-/ If we need
> it to work, maybe one can test for vlan in main() whith the test for
> create or plumb?
>
>
>   
Ah, I see now, the cmd that didn't work was using the parameters w/o a 
clone operation.  It should work but is likely broke; will look at it.

    Sam