cvs commit: src/sys/net if_media.h

[Antoine Brodin]

On Wed, May 28, 2008 at 5:04 PM, Bruce M. Simpson <bms at freebsd.org> wrote:
> Gavin Atkinson wrote:
>>
>> On Tue, 2008-05-27 at 18:33 +0000, Antoine Brodin wrote:
>>>
>>>  MFC to RELENG_6:
>>>    Move "1000baseT" from IFM_SUBTYPE_ETHERNET_DESCRIPTIONS to
>>>    IFM_SUBTYPE_ETHERNET_ALIASES: there is already "1000baseTX" in
>>>    IFM_SUBTYPE_ETHERNET_DESCRIPTIONS.  This doesn't change ifconfig
>>>    behaviour.
>>>
>>
>> I'm not sure if this is any more correct than it was before.  1000baseT
>> and 1000baseTX are incompatible standards.
>>
>> See http://docs.FreeBSD.org/cgi/mid.cgi?20050307191901.H32508 for an
>> example of where this has come up before.  The real bug is probably that
>> we claim to support 1000baseTX at all.
>>
>
> That sounds pretty clear to me. Perhaps this change should be backed out and
> done the other way around (make 1000baseTX the alias) ?

The goal of this commit was to have only one description instead of
two (only the first one is printed by ifconfig and dmesg).  So the
commit didn't change the existing behaviour of ifconfig/dmesg.
I can swap the two lines (make 1000baseT the description and
1000baseTX the alias), but it may break existing scripts that grep
dmesg or ifconfig output for 1000baseTX.

Cheers,

Antoine