cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile

Tim Kientzle kientzle at freebsd.org
Mon Jun 9 05:01:28 UTC 2008


This case is a little unusual: by default, I want to
install both 'cpio' programs and symlink the common name
to one of them.

How about this:
    WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless 
WITH_BSDCPIO defined
    WITHOUT_GCPIO - does not install gcpio at all
    WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio'
    WITHOUT_BSDCPIO - does not install bsdcpio at all

This way, WITHOUT_BSDCPIO gives you the old behavior,
WITHOUT_GCPIO gives you the proposed new behavior;
the default gives you the transitional behavior.

Tim Kientzle


Jeremie Le Hen wrote:
> Hi Tim,
> 
> First of all, thanks for this work.  It greatly contributes to the
> cleanness of the overall source tree :-).
> 
> On Mon, May 26, 2008 at 05:21:12PM +0000, Tim Kientzle wrote:
> 
>>kientzle    2008-05-26 17:21:12 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    gnu/usr.bin/cpio     Makefile 
>>  Log:
>>  Install GNU cpio as 'gcpio', symlink to 'cpio' unless WITH_BSDCPIO is
>>  defined.
> 
> 
> There have been much work to glean all build flags over the source tree
> into a single place, namely src/share/bsd.own.mk.  See [1].  I think it
> would be better to stick to this scheme and not spread those knobs back
> in the tree.
> 
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk#rev1.44
> 
> Thanks.
> Regards,



More information about the cvs-src mailing list